Skip to content

Code Quality: Removed Vanara from shell preview handler #15911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Code Quality: Removed Vanara from shell preview handler #15911

wants to merge 2 commits into from

Conversation

@0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jul 30, 2024 •
edited
Loading

Important

This is blocked by #16156

Resolved / Related Issues

Steps used to test these changes

  1. Install previewers
    1. Microsoft Office (docx, xlsx, pptx)
    2. Adobe (ai, ps, ...)
    3. Adobe Acrobat or PowerToys (pdf)
  2. Open any file above
  3. Open Preview tab
  4. See preview is shown correctly and as before.

@yaira2 yaira2 self-requested a review July 30, 2024 23:54
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Jul 30, 2024
@yaira2
Copy link
Member

yaira2 commented Jul 30, 2024

Aside from testing shell previews, are there any other things to look out for?

@0x5bfa 0x5bfa changed the title Code Quality: Removed Vanara reference from PreviewHandler class Code Quality: Removed Vanara from shell preview handler Jul 31, 2024
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-PreviewHandlerVanaraRemoval branch from 52a03d6 to 1a67dc9 Compare August 3, 2024 17:49
@0x5bfa 0x5bfa marked this pull request as draft August 21, 2024 15:11
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-PreviewHandlerVanaraRemoval branch 2 times, most recently from 1f85e2f to bdc4541 Compare August 30, 2024 07:05
@0x5bfa 0x5bfa mentioned this pull request Sep 3, 2024
Closed
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-PreviewHandlerVanaraRemoval branch from 55c40d7 to 3cdf047 Compare September 24, 2024 22:03
@yaira2 yaira2 closed this Jan 14, 2025
@0x5bfa 0x5bfa deleted the 5bfa/CQ-PreviewHandlerVanaraRemoval branch April 4, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 Awaiting requested review from yaira2

Assignees

No one assigned

Labels

ready for review Pull requests that are ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0x5bfa @yaira2